Commit 00999d99 authored by Dmytro Laktyushkin's avatar Dmytro Laktyushkin Committed by Alex Deucher
Browse files

drm/amd/display: clean up validation failure log spam 



Currently dcn2+ validation will unconditionally print a failure
reason before validation completes. This change categorizes the
failure reason as a warning log and only prints at the end of
validation resolving false positives.

Signed-off-by: default avatarDmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Reviewed-by: default avatarNikola Cornij <Nikola.Cornij@amd.com>
Acked-by: default avatarLeo Li <sunpeng.li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 0cd32625

drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c

+3 −0
Original line number Diff line number Diff line
@@ -1880,6 +1880,7 @@ bool dcn20_validate_bandwidth(struct dc *dc, 
	int split_threshold = dc->res_pool->pipe_count / 2;

	bool avoid_split = dc->debug.pipe_split_policy != MPC_SPLIT_DYNAMIC;

	display_e2e_pipe_params_st *pipes = kzalloc(dc->res_pool->pipe_count * sizeof(display_e2e_pipe_params_st), GFP_KERNEL);

	DC_LOGGER_INIT(dc->ctx->logger);



	ASSERT(pipes);

	if (!pipes)
@@ -2183,6 +2184,8 @@ validate_pass: 
	return true;



validate_fail:

	DC_LOG_WARNING("Mode Validation Warning: %s failed validation.\n",

		dml_get_status_message(context->bw_ctx.dml.vba.ValidationStatus[context->bw_ctx.dml.vba.soc.num_states]));

	kfree(pipes);

	return false;

}

drivers/gpu/drm/amd/display/dc/dml/display_mode_vba.c

+1 −11
Original line number Diff line number Diff line
@@ -75,16 +75,6 @@ unsigned int dml_get_voltage_level( 
	}

	mode_lib->funcs.validate(mode_lib);



	/* check if Mode Support Validation failed */

	if (mode_lib->vba.VoltageLevel > mode_lib->vba.soc.num_states) {

		/* get the validation status for highest voltage level and output console message */

		enum dm_validation_status status = mode_lib->vba.ValidationStatus[mode_lib->vba.soc.num_states];

		if (status != DML_FAIL_PITCH_SUPPORT) {

			/*AlignedYPitch is based on swizzle mode, so it is normal if some swizzle mode not supported*/

			dm_output_to_console("Mode Validation Error: %s failed validation.\n", dml_get_status_message(status));

		}

	}



	return mode_lib->vba.VoltageLevel;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE