Commit 00760d3c authored by Marek Vasut's avatar Marek Vasut Committed by Marc Zyngier
Browse files

irqchip/stm32: Retrigger both in eoi and unmask callbacks 



Sampling the IRQ line state in EOI and retriggering the interrupt to
work around missing level-triggered interrupt support only works for
non-threaded interrupts. Threaded interrupts must be retriggered the
same way in unmask callback.

Signed-off-by: default avatarMarek Vasut <marex@denx.de>
[maz: fixed missing static attribute]
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200323235132.530550-1-marex@denx.de
parent eeaa4b24

drivers/pinctrl/stm32/pinctrl-stm32.c

+14 −4
Original line number Diff line number Diff line
@@ -304,18 +304,22 @@ static const struct gpio_chip stm32_gpio_template = { 
	.get_direction		= stm32_gpio_get_direction,

};



void stm32_gpio_irq_eoi(struct irq_data *d)

static void stm32_gpio_irq_trigger(struct irq_data *d)

{

	struct stm32_gpio_bank *bank = d->domain->host_data;

	int level;



	irq_chip_eoi_parent(d);



	/* If level interrupt type then retrig */

	level = stm32_gpio_get(&bank->gpio_chip, d->hwirq);

	if ((level == 0 && bank->irq_type[d->hwirq] == IRQ_TYPE_LEVEL_LOW) ||

	    (level == 1 && bank->irq_type[d->hwirq] == IRQ_TYPE_LEVEL_HIGH))

		irq_chip_retrigger_hierarchy(d);

}



static void stm32_gpio_irq_eoi(struct irq_data *d)

{

	irq_chip_eoi_parent(d);

	stm32_gpio_irq_trigger(d);

};



static int stm32_gpio_set_type(struct irq_data *d, unsigned int type)
@@ -371,12 +375,18 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) 
	gpiochip_unlock_as_irq(&bank->gpio_chip, irq_data->hwirq);

}



static void stm32_gpio_irq_unmask(struct irq_data *d)

{

	irq_chip_unmask_parent(d);

	stm32_gpio_irq_trigger(d);

}



static struct irq_chip stm32_gpio_irq_chip = {

	.name		= "stm32gpio",

	.irq_eoi	= stm32_gpio_irq_eoi,

	.irq_ack	= irq_chip_ack_parent,

	.irq_mask	= irq_chip_mask_parent,

	.irq_unmask	= irq_chip_unmask_parent,

	.irq_unmask	= stm32_gpio_irq_unmask,

	.irq_set_type	= stm32_gpio_set_type,

	.irq_set_wake	= irq_chip_set_wake_parent,

	.irq_request_resources = stm32_gpio_irq_request_resources,

CRA Git | Maintained and supported by SUSTech CRA and CCSE