Commit 00740c58 authored Sep 26, 2010 by Borislav Petkov

amd64_edac: Fix driver module removal



f4347553 removed the edac polling
mechanism in favor of using a notifier chain for conveying MCE
information to edac. However, the module removal path didn't test
whether the driver had setup the polling function workqueue at all and
the rmmod process was hanging in the kernel at try_to_del_timer_sync()
in the cancel_delayed_work() path, trying to cancel an uninitialized
work struct.

Fix that by adding a balancing check to the workqueue removal path.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>

parent b30a3f62

drivers/edac/edac_mc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -339,6 +339,9 @@ static void edac_mc_workq_teardown(struct mem_ctl_info *mci)
		{
		int status;

		if (mci->op_state != OP_RUNNING_POLL)
		return;

		status = cancel_delayed_work(&mci->work);
		if (status == 0) {
		debugf0("%s() not canceled, flush the queue\n",

Admin message