Commit 006e5701 authored Sep 30, 2019 by Ville Syrjälä

drm/i915: Fix g4x sprite scaling stride check with GTT remapping



I forgot to update the g4x sprite scaling stride check when GTT
remapping was introduced. The stride of the original framebuffer
is irrelevant when remapping is used and instead we want to check
the stride of the remapped view.

Also drop the duplicate width_bytes check. We already check that
a few lines earlier.

Fixes: df79cf44 ("drm/i915: Store the final plane stride in plane_state")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190930183045.662-1-ville.syrjala@linux.intel.com


Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

parent 15de0889

drivers/gpu/drm/i915/display/intel_sprite.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1516,6 +1516,7 @@ g4x_sprite_check_scaling(struct intel_crtc_state *crtc_state,
		int src_x, src_w, src_h, crtc_w, crtc_h;
		const struct drm_display_mode *adjusted_mode =
		&crtc_state->base.adjusted_mode;
		unsigned int stride = plane_state->color_plane[0].stride;
		unsigned int cpp = fb->format->cpp[0];
		unsigned int width_bytes;
		int min_width, min_height;
		@@ -1557,9 +1558,9 @@ g4x_sprite_check_scaling(struct intel_crtc_state *crtc_state,
		return -EINVAL;
		}

		if (width_bytes > 4096 \|\| fb->pitches[0] > 4096) {
		if (stride > 4096) {
		DRM_DEBUG_KMS("Stride (%u) exceeds hardware max with scaling (%u)\n",
		fb->pitches[0], 4096);
		stride, 4096);
		return -EINVAL;
		}

Admin message