Commit 004f3885 authored Apr 07, 2014 by Daniel Vetter Committed by Jani Nikula Apr 10, 2014

drm/mm: Don't WARN if drm_mm_reserve_node



Jesse's BIOS fb reconstruction code actually relies on the -ENOSPC
return value to detect overlapping framebuffers (which the bios uses
always when lighting up more than one screen). All this fanciness
happens in intel_alloc_plane_obj in intel_display.c.

Since no one else uses this we can safely remove the WARN without
repercussions.

Reported-by: Ben Widawsky <benjamin.widawsky@intel.com>
Tested-by: Ben Widawsky <ben@bwidawsk.net>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Dave Airlie <airlied@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

parent c39b0695

drivers/gpu/drm/drm_mm.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -207,8 +207,6 @@ int drm_mm_reserve_node(struct drm_mm mm, struct drm_mm_node node)
		return 0;
		}

		WARN(1, "no hole found for node 0x%lx + 0x%lx\n",
		node->start, node->size);
		return -ENOSPC;
		}
		EXPORT_SYMBOL(drm_mm_reserve_node);

Admin message