Commit 00161f7d authored Apr 28, 2011 by Sarah Sharp

xhci: Remove sparse warning about cmd_status.

Sparse complains about the arguments to xhci_evaluate_context_result() and
xhci_configure_endpoint_result():

CHECK drivers/usb/host/xhci.c
drivers/usb/host/xhci.c:1647:53: warning: incorrect type in argument 3 (different signedness)
drivers/usb/host/xhci.c:1647:53: expected int *cmd_status
drivers/usb/host/xhci.c:1647:53: got unsigned int [usertype] *[assigned] cmd_status
drivers/usb/host/xhci.c:1648:50: warning: incorrect type in argument 3 (different signedness)
drivers/usb/host/xhci.c:1648:50: expected int *cmd_status
drivers/usb/host/xhci.c:1648:50: got unsigned int [usertype] *[assigned] cmd_status

The command status is taken from the command completion event TRB, and
will always be a positive number. Change the signature of
xhci_evaluate_context_result() and xhci_configure_endpoint_result() to
take a u32 for cmd_status.

Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

parent 5e467f6e

drivers/usb/host/xhci.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1502,7 +1502,7 @@ static void xhci_zero_in_ctx(struct xhci_hcd xhci, struct xhci_virt_device vir
		}

		static int xhci_configure_endpoint_result(struct xhci_hcd *xhci,
		struct usb_device udev, int cmd_status)
		struct usb_device udev, u32 cmd_status)
		{
		int ret;

		@@ -1540,7 +1540,7 @@ static int xhci_configure_endpoint_result(struct xhci_hcd *xhci,
		}

		static int xhci_evaluate_context_result(struct xhci_hcd *xhci,
		struct usb_device udev, int cmd_status)
		struct usb_device udev, u32 cmd_status)
		{
		int ret;
		struct xhci_virt_device *virt_dev = xhci->devs[udev->slot_id];

Admin message