Fixes BGPv6 bug - mandatory attributes weren't validated; (f307842a) · Commits · 戴 / Bird

proto/bgp/attrs.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -1355,11 +1355,11 @@ bgp_decode_attrs(struct bgp_conn conn, byte attr, unsigned int len, struct lin
		}

		#ifdef IPV6
		if (seen[BA_MP_REACH_NLRI / 8] & (1 << (BA_MP_REACH_NLRI % 8)))
		/* If we received MP_REACH_NLRI we should check mandatory attributes */
		if (bgp->mp_reach_len != 0)
		mandatory = 1;
		#endif


		/* If there is no (reachability) NLRI, we should exit now */
		if (! mandatory)
		return a;
		@@ -1396,6 +1396,7 @@ bgp_decode_attrs(struct bgp_conn conn, byte attr, unsigned int len, struct lin
		/* If there's no local preference, define one */
		if (!(seen[0] & (1 << BA_LOCAL_PREF)))
		bgp_attach_attr(&a->eattrs, pool, BA_LOCAL_PREF, 0);

		return a;

		loop: