Commit a7c9515e authored by Stefan Haller's avatar Stefan Haller Committed by Ondrej Zajicek (work)
Browse files

BSD: Fix invalid pointer derefence in logging code 

For logging purposes a stack allocated net_addr struct was passed by
value as vararg (instead of the expected pointer). This resulted in
a segfault when the specific error condition got logged.
parent 9c41e1ca

sysdep/bsd/krt-sock.c

+1 −1
Original line number Diff line number Diff line
@@ -453,7 +453,7 @@ krt_read_route(struct ks_msg *msg, struct krt_proto *p, int scan) 
    net_fill_ip4(&ndst, ipa_to_ip4(idst), pxlen);



  if ((flags & RTF_GATEWAY) && ipa_zero(igate))

    { log(L_ERR "%s (%N) - missing gateway", errmsg, ndst); return; }

    { log(L_ERR "%s (%N) - missing gateway", errmsg, &ndst); return; }



  u32 self_mask = RTF_PROTO1;

  u32 alien_mask = RTF_STATIC | RTF_PROTO1 | RTF_GATEWAY;

CRA Git | Maintained and supported by SUSTech CRA and CCSE