BGP: split tx explicitly (9dac814e) · Commits · 戴 / Bird

If BGP has too many data to send and BIRD is slower than the link, TX is always possible until all data is sent. This patch limits maximum number of generated BGP messages in one iteration of TX hook.

proto/bgp/packets.c

+10 −3

Original line number	Diff line number	Diff line
		@@ -2789,15 +2789,18 @@ bgp_schedule_packet(struct bgp_conn conn, struct bgp_channel c, int type)
		if ((conn->sk->tpos == conn->sk->tbuf) && !ev_active(conn->tx_ev))
		ev_schedule(conn->tx_ev);
		}

		void
		bgp_kick_tx(void *vconn)
		{
		struct bgp_conn *conn = vconn;

		DBG("BGP: kicking TX\n");
		while (bgp_fire_tx(conn) > 0)
		uint max = 1024;
		while (--max && (bgp_fire_tx(conn) > 0))
		;

		if (!max && !ev_active(conn->tx_ev))
		ev_schedule(conn->tx_ev);
		}

		void
		@@ -2806,8 +2809,12 @@ bgp_tx(sock *sk)
		struct bgp_conn *conn = sk->data;

		DBG("BGP: TX hook\n");
		while (bgp_fire_tx(conn) > 0)
		uint max = 1024;
		while (--max && (bgp_fire_tx(conn) > 0))
		;

		if (!max && !ev_active(conn->tx_ev))
		ev_schedule(conn->tx_ev);
		}

Admin message