Commit 864f52a5 authored by Ondrej Zajicek's avatar Ondrej Zajicek
Browse files

Fixes nasty bug in BFD. 

When a BFD session is removed while being scheduled for notification,
the session stays in notify list and is removed twice, which leads to
a strange crash after a while.
parent 60442b16

proto/bfd/bfd.c

+7 −0
Original line number Diff line number Diff line
@@ -477,8 +477,15 @@ bfd_remove_session(struct bfd_proto *p, struct bfd_session *s) 
{

  ip_addr ip = s->addr;



  /* Caller should ensure that request list is empty */



  birdloop_enter(p->loop);



  /* Remove session from notify list if scheduled for notification */

  /* No need for bfd_lock_sessions(), we are already protected by birdloop_enter() */

  if (NODE_VALID(&s->n))

    rem_node(&s->n);



  bfd_free_iface(s->ifa);



  rfree(s->tx_timer);

CRA Git | Maintained and supported by SUSTech CRA and CCSE