BGP: Do not keep BAF_EXT_LEN flag internally (7a74ad5a) · Commits · 戴 / Bird

The flag makes sense just in external representation. It is reset during BGP export, but keeping it internally broke MRT dumps for short attributes that used it anyways. Thanks to Simon Marsh for the bugreport and the patch.

proto/bgp/attrs.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -88,7 +88,7 @@ bgp_set_attr(ea_list *attrs, struct linpool pool, uint code, uint flags, uintp
		attrs,
		pool,
		EA_CODE(PROTOCOL_BGP, code),
		flags,
		flags & ~BAF_EXT_LEN,
		bgp_attr_table[code].type,
		val
		);
		@@ -118,7 +118,7 @@ bgp_set_attr(ea_list *attrs, struct linpool pool, uint code, uint flags, uintp
		static inline int
		bgp_put_attr_hdr3(byte *buf, uint code, uint flags, uint len)
		{
		*buf++ = flags;
		*buf++ = flags & ~BAF_EXT_LEN;
		*buf++ = code;
		*buf++ = len;
		return 3;

Admin message