Commit 051f258c authored by Maria Matejka's avatar Maria Matejka
Browse files

OSPF: variable-length array of size 0 replaced by alloca()'d pointer

NULL pointer is safer than a random pointer onto stack if this function
gets changed and eventually broken.
parent 05b8620a
Loading
Loading
Loading
Loading
+4 −2
Original line number Diff line number Diff line
@@ -1289,7 +1289,7 @@ ospf_sh_state(struct proto *P, int verbose, int reachable)

  uint num = p->gr->hash_entries;
  struct top_hash_entry *hea[num];
  struct top_hash_entry *hex[verbose ? num : 0];
  struct top_hash_entry **hex = verbose ? alloca(num * sizeof(struct top_hash_entry *)) : NULL;
  struct top_hash_entry *he;
  struct top_hash_entry *cnode = NULL;

@@ -1334,6 +1334,8 @@ ospf_sh_state(struct proto *P, int verbose, int reachable)

  lsa_compare_ospf3 = !ospf2;
  qsort(hea, j1, sizeof(struct top_hash_entry *), lsa_compare_for_state);

  if (verbose)
    qsort(hex, jx, sizeof(struct top_hash_entry *), ext_compare_for_state);

  /*