Commit fc8b53bf authored by Andrei Emeltchenko's avatar Andrei Emeltchenko Committed by Fabio Baltieri
Browse files

drivers: pcie: Read register before actual usage 



Move reading PCIE_CONF_CMDSTAT before actual usage. There are four
return branches before value is used.

Signed-off-by: default avatarAndrei Emeltchenko <andrei.emeltchenko@intel.com>
parent 4a174466

drivers/pcie/host/pcie.c

+3 −1
Original line number Diff line number Diff line
@@ -126,7 +126,7 @@ static bool pcie_get_bar(pcie_bdf_t bdf, 
			 bool io)

{

	uint32_t reg = bar_index + PCIE_CONF_BAR0;

	uint32_t cmd_reg = pcie_conf_read(bdf, PCIE_CONF_CMDSTAT);

	uint32_t cmd_reg;

	bool ret = false;

#ifdef CONFIG_PCIE_CONTROLLER

	const struct device *dev;
@@ -158,6 +158,8 @@ static bool pcie_get_bar(pcie_bdf_t bdf, 
		return false;

	}



	cmd_reg = pcie_conf_read(bdf, PCIE_CONF_CMDSTAT);



	/* IO/memory decode should be disabled before sizing/update BAR. */

	pcie_conf_write(bdf, PCIE_CONF_CMDSTAT,

			cmd_reg & (~(PCIE_CONF_CMDSTAT_IO | PCIE_CONF_CMDSTAT_MEM)));

CRA Git | Maintained and supported by SUSTech CRA and CCSE