lib: hex: Code guideline fixes (ec69bda0) · Commits · Wenxi XU / zephyr

Fixes violations code guideline related with essential types rules: - Avoid mixing characters with integers - Ensure computations are done in the destination precision Signed-off-by:

Flavio Ceolin <flavio.ceolin@intel.com> Signed-off-by:

Abramo Bagnara <abramo.bagnara@bugseng.com>

lib/os/hex.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -12,11 +12,11 @@
		int char2hex(char c, uint8_t *x)
		{
		if (c >= '0' && c <= '9') {
		*x = c - '0';
		*x = (uint8_t)(int)(c - '0');
		} else if (c >= 'a' && c <= 'f') {
		*x = c - 'a' + 10;
		*x = (uint8_t)(int)(c - 'a' + 10);
		} else if (c >= 'A' && c <= 'F') {
		*x = c - 'A' + 10;
		*x = (uint8_t)(int)(c - 'A' + 10);
		} else {
		return -EINVAL;
		}
		@@ -47,7 +47,7 @@ size_t bin2hex(const uint8_t buf, size_t buflen, char hex, size_t hexlen)
		if (hex2char(buf[i] >> 4, &hex[2 * i]) < 0) {
		return 0;
		}
		if (hex2char(buf[i] & 0xf, &hex[2 * i + 1]) < 0) {
		if (hex2char(buf[i] & 0x0FU, &hex[2 * i + 1]) < 0) {
		return 0;
		}
		}

Admin message