Bluetooth: audio: vocs: Fix missing instance type checks (e84d76f9) · Commits · Wenxi XU / zephyr

subsys/bluetooth/audio/vocs.c

+10 −0

Original line number	Diff line number	Diff line
		@@ -287,6 +287,11 @@ void bt_vocs_svc_decl_get(struct bt_vocs vocs)
		return NULL;
		}

		CHECKIF(vocs->client_instance) {
		LOG_DBG("vocs pointer shall be server instance");
		return NULL;
		}

		return vocs->srv.service_p->attrs;
		}

		@@ -310,6 +315,11 @@ int bt_vocs_register(struct bt_vocs *vocs,
		return -EINVAL;
		}

		CHECKIF(vocs->client_instance) {
		LOG_DBG("vocs pointer shall be server instance");
		return -EINVAL;
		}

		CHECKIF(!param) {
		LOG_DBG("NULL params pointer");
		return -EINVAL;

+10 −0

Original line number	Diff line number	Diff line
		@@ -716,6 +716,11 @@ int bt_vocs_discover(struct bt_conn conn, struct bt_vocs inst,
		return -EINVAL;
		}

		CHECKIF(!inst->client_instance) {
		LOG_DBG("vocs pointer shall be client instance");
		return -EINVAL;
		}

		CHECKIF(param->end_handle < param->start_handle) {
		LOG_DBG("start_handle (%u) shall be less than end_handle (%u)", param->start_handle,
		param->end_handle);
		@@ -757,5 +762,10 @@ void bt_vocs_client_cb_register(struct bt_vocs inst, struct bt_vocs_cb cb)
		return;
		}

		CHECKIF(!inst->client_instance) {
		LOG_DBG("vocs pointer shall be client instance");
		return;
		}

		inst->cli.cb = cb;
		}