Commit e34542a3 authored by Théo Battrel's avatar Théo Battrel Committed by Anas Nashif
Browse files

Shell: Make `full_line_cmd` return false on empty lines 



The fact that the function was returning `true` for empty line was an
unexpected behavior according to the name of the function itself and how
it was used elsewhere.

Signed-off-by: default avatarThéo Battrel <theo.battrel@nordicsemi.no>
parent e2b34b96

subsys/shell/shell_ops.c

+7 −2
Original line number Diff line number Diff line
@@ -43,8 +43,13 @@ void z_shell_op_cursor_horiz_move(const struct shell *sh, int32_t delta) 
 */

static inline bool full_line_cmd(const struct shell *sh)

{

	return ((sh->ctx->cmd_buff_len + z_shell_strlen(sh->ctx->prompt))

			% sh->ctx->vt100_ctx.cons.terminal_wid == 0U);

	size_t line_length = sh->ctx->cmd_buff_len + z_shell_strlen(sh->ctx->prompt);



	if (line_length == 0) {

		return false;

	}



	return (line_length % sh->ctx->vt100_ctx.cons.terminal_wid == 0U);

}



/* Function returns true if cursor is at beginning of an empty line. */

CRA Git | Maintained and supported by SUSTech CRA and CCSE