west: sign.py: de-duplicate the bootloader condition (e1f36c40) · Commits · Wenxi XU / zephyr

De-duplicate the `if target in ('imx8', 'imx8m'):` copy/paste/diverge before someone updates one and not the other. Also better to define bootloader always. Zero functional change. Signed-off-by:

Marc Herbert <marc.herbert@intel.com>

scripts/west_commands/sign.py

+3 −1

Changes for scripts/west_commands/sign.py: 3 added lines, 1 removed line.
Original line number	Diff line number	Diff line
		@@ -430,7 +430,9 @@ class RimageSigner(Signer):
		if not target:
		log.die('rimage target not defined')

		# TODO: make this a new sign.py --bootloader option.
		if target in ('imx8', 'imx8m'):
		bootloader = None
		kernel = str(b / 'zephyr' / 'zephyr.elf')
		out_bin = str(b / 'zephyr' / 'zephyr.ri')
		out_xman = str(b / 'zephyr' / 'zephyr.ri.xman')
		@@ -516,7 +518,7 @@ class RimageSigner(Signer):
		if not args.quiet and args.verbose:
		sign_base += ['-v'] * args.verbose

		components = [ ] if (target in ('imx8', 'imx8m')) else [ bootloader ]
		components = [ ] if bootloader is None else [ bootloader ]
		components += [ kernel ]

		sign_config_extra_args = config_get_words(command.config, 'rimage.extra-args', [])

Admin message