lorawan: move public network request (ddc595b6) · Commits · Wenxi XU / zephyr

Move the public network request command from the end of `lorawan_start` to the start of `lorawan_join`. This MAC command interacts with the radio driver, bringing it out of sleep mode, and doesn't put it back. The public network setting is only needed when joining a network, and `lorawan_start` can be called well before `lorawan_join`. By moving the command we save ~600uA before joining (for sx1262). Signed-off-by:

Jordan Yates <jordan.yates@data61.csiro.au>

subsys/lorawan/lorawan.c

+6 −4

Original line number	Diff line number	Diff line
		@@ -222,11 +222,17 @@ static LoRaMacStatus_t lorawan_join_abp(

		int lorawan_join(const struct lorawan_join_config *join_cfg)
		{
		MibRequestConfirm_t mib_req;
		LoRaMacStatus_t status;
		int ret = 0;

		k_mutex_lock(&lorawan_join_mutex, K_FOREVER);

		/* MIB_PUBLIC_NETWORK powers on the radio and does not turn it off */
		mib_req.Type = MIB_PUBLIC_NETWORK;
		mib_req.Param.EnablePublicNetwork = true;
		LoRaMacMibSetRequestConfirm(&mib_req);

		if (join_cfg->mode == LORAWAN_ACT_OTAA) {
		status = lorawan_join_otaa(join_cfg);
		if (status != LORAMAC_STATUS_OK) {
		@@ -460,10 +466,6 @@ int lorawan_start(void)
		mib_req.Param.SystemMaxRxError = CONFIG_LORAWAN_SYSTEM_MAX_RX_ERROR;
		LoRaMacMibSetRequestConfirm(&mib_req);

		mib_req.Type = MIB_PUBLIC_NETWORK;
		mib_req.Param.EnablePublicNetwork = true;
		LoRaMacMibSetRequestConfirm(&mib_req);

		return 0;
		}

Admin message