Commit dd180c27 authored Jun 27, 2025 by Gaetan Perrot Committed by Dan Kalowsky Jul 11, 2025

ipc_service: ipc_icbmsg: fix unchecked error in icmsg_open()

Coverity (CID 516253) reported that the return value of
initialize_tx_with_sid_disabled() was set but not used, leading to
potential silent failures.

Check if the return value is negative and propagate the error through the
existing cleanup path.

Fixes: CID 516253

Signed-off-by: Gaetan Perrot <gaetan.perrot@spacecubics.com>

parent e4e88701

subsys/ipc/ipc_service/lib/icmsg.c

+3 −0

Changes for subsys/ipc/ipc_service/lib/icmsg.c: 3 added lines, 0 removed lines.
Original line number	Diff line number	Diff line
		@@ -436,6 +436,9 @@ int icmsg_open(const struct icmsg_config_t *conf,
		MAKE_RX_HANDSHAKE(dev_data->local_sid, SID_DISCONNECTED));
		} else if (UNBOUND_DISABLED) {
		ret = initialize_tx_with_sid_disabled(dev_data);
		if (ret < 0) {
		goto cleanup_and_exit;
		}
		}

		if (old_state == ICMSG_STATE_OFF && (UNBOUND_ENABLED \|\| UNBOUND_DETECT)) {

Admin message