Commit dcf4855f authored by Etienne Carriere's avatar Etienne Carriere Committed by Anas Nashif
Browse files

drivers: clock_control: fix IN_RANGE() use in stm32 clock drivers 



IN_RANGE() macro from zephyr/sys/util.h returns a boolean value
so it should be treated as such and not compared to a decimal value.
Fix stm32 clock drivers accordingly and simplify places where the
value is compared to true.

No functional change.

Signed-off-by: default avatarEtienne Carriere <etienne.carriere@st.com>
parent 6c2d354d

drivers/clock_control/clock_stm32_ll_common.c

+3 −3
Original line number Diff line number Diff line
@@ -255,7 +255,7 @@ static inline int stm32_clock_control_on(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to change a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -278,7 +278,7 @@ static inline int stm32_clock_control_off(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -498,7 +498,7 @@ static enum clock_control_status stm32_clock_control_get_status(const struct dev 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == true) {

	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Gated clocks */

		if ((sys_read32(DT_REG_ADDR(DT_NODELABEL(rcc)) + pclken->bus) & pclken->enr)

		    == pclken->enr) {

drivers/clock_control/clock_stm32_ll_h5.c

+2 −2
Original line number Diff line number Diff line
@@ -152,7 +152,7 @@ static inline int stm32_clock_control_on(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -173,7 +173,7 @@ static inline int stm32_clock_control_off(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}

drivers/clock_control/clock_stm32_ll_h7.c

+2 −2
Original line number Diff line number Diff line
@@ -390,7 +390,7 @@ static inline int stm32_clock_control_on(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -416,7 +416,7 @@ static inline int stm32_clock_control_off(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}

drivers/clock_control/clock_stm32_ll_n6.c

+2 −2
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ static inline int stm32_clock_control_on(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -221,7 +221,7 @@ static inline int stm32_clock_control_off(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}

drivers/clock_control/clock_stm32_ll_u5.c

+3 −3
Original line number Diff line number Diff line
@@ -158,7 +158,7 @@ static inline int stm32_clock_control_on(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -179,7 +179,7 @@ static inline int stm32_clock_control_off(const struct device *dev, 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == 0) {

	if (!IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Attempt to toggle a wrong periph clock bit */

		return -ENOTSUP;

	}
@@ -373,7 +373,7 @@ static enum clock_control_status stm32_clock_control_get_status(const struct dev 


	ARG_UNUSED(dev);



	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX) == true) {

	if (IN_RANGE(pclken->bus, STM32_PERIPH_BUS_MIN, STM32_PERIPH_BUS_MAX)) {

		/* Gated clocks */

		if ((sys_read32(DT_REG_ADDR(DT_NODELABEL(rcc)) + pclken->bus) & pclken->enr)

		    == pclken->enr) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE