Commit c3d715c6 authored by Flavio Ceolin's avatar Flavio Ceolin Committed by Anas Nashif
Browse files

lib: sem: Code guideline fixes 



Fixes violations code guideline related with essential types rules:

- avoid mixing signed and unsigned integers in computations and
  comparisons

Signed-off-by: default avatarFlavio Ceolin <flavio.ceolin@intel.com>
Signed-off-by: default avatarAbramo Bagnara <abramo.bagnara@bugseng.com>
parent f5884c7d

lib/os/sem.c

+5 −5
Original line number Diff line number Diff line
@@ -48,13 +48,13 @@ static inline atomic_t bounded_inc(atomic_t *val, atomic_t minimum, 
int sys_sem_init(struct sys_sem *sem, unsigned int initial_count,

		 unsigned int limit)

{

	if (sem == NULL || limit == SYS_SEM_MINIMUM ||

	    initial_count > limit || limit > INT_MAX) {

	if (sem == NULL || limit == (unsigned int)SYS_SEM_MINIMUM ||

	    initial_count > limit || limit > (unsigned int)INT_MAX) {

		return -EINVAL;

	}



	atomic_set(&sem->futex.val, initial_count);

	sem->limit = limit;

	atomic_set(&sem->futex.val, (int)initial_count);

	sem->limit = (int)limit;



	return 0;

}
@@ -103,7 +103,7 @@ unsigned int sys_sem_count_get(struct sys_sem *sem) 
{

	int value = atomic_get(&sem->futex.val);



	return value > SYS_SEM_MINIMUM ? value : SYS_SEM_MINIMUM;

	return (unsigned int)(value > SYS_SEM_MINIMUM ? value : SYS_SEM_MINIMUM);

}

#else

int sys_sem_init(struct sys_sem *sem, unsigned int initial_count,

CRA Git | Maintained and supported by SUSTech CRA and CCSE