Commit c1af0c22 authored by Vinayak Kariappa Chettimada's avatar Vinayak Kariappa Chettimada Committed by Anas Nashif
Browse files

Bluetooth: controller: legacy: Fix dev assert in CPR implementation 

Replace a development assertion in the implementation of
Connection Parameter Request Procedure with an internal
comment and handle transaction violation be ignoring the
PDU.

Relates to commit dec61406 ("Bluetooth: controller: Fix
dev assert in CPR implementation").

Signed-off-by: default avatarVinayak Kariappa Chettimada <vich@nordicsemi.no>
parent a2195986

subsys/bluetooth/controller/ll_sw/ctrl.c

+4 −1
Changes for subsys/bluetooth/controller/ll_sw/ctrl.c: 4 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -3288,7 +3288,10 @@ isr_rx_conn_pkt_ctrl(struct radio_pdu_node_rx *node_rx, 
				_radio.conn_upd = conn;

			}

		} else {

			LL_ASSERT(0);

			/* Ignore duplicate request as peripheral is busy

			 * processing the previously initiated connection

			 * update request procedure.

			 */

		}

		break;

subsys/bluetooth/controller/ll_sw/ull_conn.c

+6 −1
Changes for subsys/bluetooth/controller/ll_sw/ull_conn.c: 6 added lines, 1 removed line.
Original line number Diff line number Diff line
@@ -4437,7 +4437,12 @@ static inline int ctrl_rx(memq_link_t *link, struct node_rx_pdu **rx, 
				conn_upd_curr = conn;

			}

		} else {

			LL_ASSERT(0);

			/* Ignore duplicate request as peripheral is busy

			 * processing the previously initiated connection

			 * update request procedure.

			 */

			/* Mark for buffer for release */

			(*rx)->hdr.type = NODE_RX_TYPE_DC_PDU_RELEASE;

		}

		break;

CRA Git | Maintained and supported by SUSTech CRA and CCSE