Commit 9844851b authored by Emil Gydesen's avatar Emil Gydesen Committed by Benjamin Cabé
Browse files

Bluetooth: BAP: SD: Fix missing clear of notify flag on reject 



For add and modify source, if the request was rejected by the
application layer, the BASS_RECV_STATE_INTERNAL_FLAG_NOTIFY_PEND
would be set but not unset.

Add unsetting the flag on reject.

Signed-off-by: default avatarEmil Gydesen <emil.gydesen@nordicsemi.no>
parent f630c6f6

subsys/bluetooth/audio/bap_scan_delegator.c

+9 −0
Original line number Diff line number Diff line
@@ -679,6 +679,9 @@ static int scan_delegator_add_source(struct bt_conn *conn, 
			LOG_DBG("PA sync %u from %p was rejected with reason %d", pa_sync, conn,

				err);



			atomic_clear_bit(internal_state->flags,

					 BASS_RECV_STATE_INTERNAL_FLAG_NOTIFY_PEND);



			return BT_GATT_ERR(BT_ATT_ERR_WRITE_REQ_REJECTED);

		}

	}
@@ -875,6 +878,9 @@ static int scan_delegator_mod_src(struct bt_conn *conn, 
			LOG_DBG("PA sync %u from %p was rejected with reason %d", pa_sync, conn,

				err);



			atomic_clear_bit(internal_state->flags,

					 BASS_RECV_STATE_INTERNAL_FLAG_NOTIFY_PEND);



			return BT_GATT_ERR(BT_ATT_ERR_WRITE_REQ_REJECTED);

		}

	} else if (pa_sync == BT_BAP_BASS_PA_REQ_NO_SYNC &&
@@ -886,6 +892,9 @@ static int scan_delegator_mod_src(struct bt_conn *conn, 
		if (err != 0) {

			LOG_DBG("PA sync term from %p was rejected with reason %d", conn, err);



			atomic_clear_bit(internal_state->flags,

					 BASS_RECV_STATE_INTERNAL_FLAG_NOTIFY_PEND);



			return BT_GATT_ERR(BT_ATT_ERR_WRITE_REQ_REJECTED);

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE