lib: updatehub: Fix build warnings (92f9cd9f) · Commits · Wenxi XU / zephyr

lib/updatehub/updatehub.c

+9 −11

Changes for lib/updatehub/updatehub.c: 9 added lines, 11 removed lines.
Original line number	Diff line number	Diff line
		/*
		* Copyright (c) 2018, 2019 O.S.Systems
		* Copyright (c) 2018-2020 O.S.Systems
		*
		* SPDX-License-Identifier: Apache-2.0
		*/
		@@ -66,6 +66,8 @@ static struct update_info {
		int image_size;
		} update_info;

		static struct k_delayed_work updatehub_work_handle;

		static void wait_fds(void)
		{
		if (poll(ctx.fds, ctx.nfds, NETWORK_TIMEOUT) < 0) {
		@@ -76,7 +78,7 @@ static void wait_fds(void)
		static void prepare_fds(void)
		{
		ctx.fds[ctx.nfds].fd = ctx.sock;
		ctx.fds[ctx.nfds].events = 1;
		ctx.fds[ctx.nfds].events = POLLIN;
		ctx.nfds++;
		}

		@@ -288,7 +290,7 @@ static int send_request(enum coap_msgtype msgtype, enum coap_method method,
		}

		ret = coap_packet_append_payload(&request_packet,
		&ctx.payload,
		ctx.payload,
		strlen(ctx.payload));
		if (ret < 0) {
		LOG_ERR("Not able to append payload");
		@@ -614,8 +616,6 @@ enum updatehub_response updatehub_probe(void)
		goto error;
		}

		k_sem_init(&ctx.semaphore, 0, 1);

		if (!boot_is_img_confirmed()) {
		LOG_ERR("The current image is not confirmed");
		ctx.code_status = UPDATEHUB_UNCONFIRMED_IMAGE;
		@@ -765,7 +765,7 @@ error:
		return ctx.code_status;
		}

		static void autohandler(struct k_delayed_work *work)
		static void autohandler(struct k_work *work)
		{
		switch (updatehub_probe()) {
		case UPDATEHUB_UNCONFIRMED_IMAGE:
		@@ -794,13 +794,11 @@ static void autohandler(struct k_delayed_work *work)
		break;
		}

		k_delayed_work_submit(work, UPDATEHUB_POLL_INTERVAL);
		k_delayed_work_submit(&updatehub_work_handle, UPDATEHUB_POLL_INTERVAL);
		}

		void updatehub_autohandler(void)
		{
		static struct k_delayed_work work;

		k_delayed_work_init(&work, autohandler);
		k_delayed_work_submit(&work, K_NO_WAIT);
		k_delayed_work_init(&updatehub_work_handle, autohandler);
		k_delayed_work_submit(&updatehub_work_handle, K_NO_WAIT);
		}

lib/updatehub/updatehub_device.c

+2 −2

Changes for lib/updatehub/updatehub_device.c: 2 added lines, 2 removed lines.
Original line number	Diff line number	Diff line
		/*
		* Copyright (c) 2018 O.S.Systems
		* Copyright (c) 2018-2020 O.S.Systems
		*
		* SPDX-License-Identifier: Apache-2.0
		*/
		@@ -7,7 +7,7 @@

		bool updatehub_get_device_identity(char *id, int id_max_len)
		{
		int i, id_len = 0, buf_len = 0;
		int i, id_len = 0;
		char buf[3];
		u8_t hwinfo_id[id_max_len];
		size_t length;

Admin message