drivers: entropy: stm32: Move clock check to post kernel operations (8e5a2cd4) · Commits · Wenxi XU / zephyr

Don't check clock configuration before kernel was started since it will prevent message to be displayed. After kernel initialization, message is still valid and then ASSERT more valuable to the user. Signed-off-by:

Erwan Gouriou <erwan.gouriou@linaro.org>

drivers/entropy/entropy_stm32.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -233,9 +233,13 @@ static int random_byte_get(void)
		unsigned int key;
		RNG_TypeDef *rng = entropy_stm32_rng_data.rng;

		if (IS_ENABLED(CONFIG_ENTROPY_STM32_CLK_CHECK)) {
		if (IS_ENABLED(CONFIG_ENTROPY_STM32_CLK_CHECK) && !k_is_pre_kernel()) {
		/* CECS bit signals that a clock configuration issue is detected,
		* which may lead to generation of non truly random data.
		*/
		__ASSERT(LL_RNG_IsActiveFlag_CECS(rng) == 0,
		"Clock configuration error. See reference manual");
		"CECS = 1: RNG domain clock is too slow.\n"
		"\tSee ref man and update target clock configuration.");
		}

		key = irq_lock();
		@@ -264,6 +268,7 @@ static int random_byte_get(void)
		}

		out:

		irq_unlock(key);

		return retval;

Admin message