Commit 8345e5eb authored by Andrew Boie's avatar Andrew Boie Committed by Anas Nashif
Browse files

syscalls: remove policy from handler checks 



The various macros to do checks in system call handlers all
implictly would generate a kernel oops if a check failed.
This is undesirable for a few reasons:

* System call handlers that acquire resources in the handler
  have no good recourse for cleanup if a check fails.
* In some cases we may want to propagate a return value back
  to the caller instead of just killing the calling thread,
  even though the base API doesn't do these checks.

These macros now all return a value, if nonzero is returned
the check failed. K_OOPS() now wraps these calls to generate
a kernel oops.

At the moment, the policy for all APIs has not changed. They
still all oops upon a failed check/

The macros now use the Z_ notation for private APIs.

Signed-off-by: default avatarAndrew Boie <andrew.p.boie@intel.com>
parent 2b9b4b2c

drivers/adc/adc_handlers.c

+12 −10
Original line number Diff line number Diff line
@@ -7,34 +7,36 @@ 
#include <adc.h>

#include <syscall_handler.h>



_SYSCALL_HANDLER(adc_enable, dev)

Z_SYSCALL_HANDLER(adc_enable, dev)

{

	_SYSCALL_DRIVER_ADC(dev, enable);

	Z_OOPS(Z_SYSCALL_DRIVER_ADC(dev, enable));

	_impl_adc_enable((struct device *)dev);

	return 0;

}



_SYSCALL_HANDLER(adc_disable, dev)

Z_SYSCALL_HANDLER(adc_disable, dev)

{

	_SYSCALL_DRIVER_ADC(dev, disable);

	Z_OOPS(Z_SYSCALL_DRIVER_ADC(dev, disable));

	_impl_adc_disable((struct device *)dev);

	return 0;

}



_SYSCALL_HANDLER(adc_read, dev, seq_table_p)

Z_SYSCALL_HANDLER(adc_read, dev, seq_table_p)

{

	struct adc_seq_entry *entry;

	struct adc_seq_table *seq_table = (struct adc_seq_table *)seq_table_p;

	int i;



	_SYSCALL_DRIVER_ADC(dev, read);

	_SYSCALL_MEMORY_READ(seq_table, sizeof(struct adc_seq_table));

	_SYSCALL_MEMORY_ARRAY_READ(seq_table->entries, seq_table->num_entries,

				   sizeof(struct adc_seq_entry));

	Z_OOPS(Z_SYSCALL_DRIVER_ADC(dev, read));

	Z_OOPS(Z_SYSCALL_MEMORY_READ(seq_table, sizeof(struct adc_seq_table)));

	Z_OOPS(Z_SYSCALL_MEMORY_ARRAY_READ(seq_table->entries,

					   seq_table->num_entries,

					   sizeof(struct adc_seq_entry)));



	for (entry = seq_table->entries, i = 0; i < seq_table->num_entries;

	     i++, entry++) {

		_SYSCALL_MEMORY_WRITE(entry->buffer, entry->buffer_length);

		Z_OOPS(Z_SYSCALL_MEMORY_WRITE(entry->buffer,

					      entry->buffer_length));

	}



	return _impl_adc_read((struct device *)dev, seq_table);

drivers/aio/aio_comparator_handlers.c

+4 −4
Original line number Diff line number Diff line
@@ -7,14 +7,14 @@ 
#include <syscall_handler.h>

#include <aio_comparator.h>



_SYSCALL_HANDLER(aio_cmp_disable, dev, index)

Z_SYSCALL_HANDLER(aio_cmp_disable, dev, index)

{

	_SYSCALL_DRIVER_AIO_CMP(dev, disable);

	Z_OOPS(Z_SYSCALL_DRIVER_AIO_CMP(dev, disable));

	return _impl_aio_cmp_disable((struct device *)dev, index);

}



_SYSCALL_HANDLER(aio_cmp_get_pending_int, dev)

Z_SYSCALL_HANDLER(aio_cmp_get_pending_int, dev)

{

	_SYSCALL_DRIVER_AIO_CMP(dev, get_pending_int);

	Z_OOPS(Z_SYSCALL_DRIVER_AIO_CMP(dev, get_pending_int));

	return _impl_aio_get_pending_int((struct device *)dev, index);

}

drivers/counter/counter_handlers.c

+2 −2
Original line number Diff line number Diff line
@@ -11,9 +11,9 @@ 
 * instance and return an integral value

 */

#define COUNTER_HANDLER(name) \

	_SYSCALL_HANDLER(counter_ ## name, dev) \

	Z_SYSCALL_HANDLER(counter_ ## name, dev) \

	{ \

		_SYSCALL_DRIVER_COUNTER(dev, name); \

		Z_OOPS(Z_SYSCALL_DRIVER_COUNTER(dev, name)); \

		return _impl_counter_ ## name((struct device *)dev); \

	}

drivers/dma/dma_handlers.c

+4 −4
Original line number Diff line number Diff line
@@ -11,15 +11,15 @@ 
 * the validity of the channel ID and returning -errno if it's bogus

 */



_SYSCALL_HANDLER(dma_start, dev, channel)

Z_SYSCALL_HANDLER(dma_start, dev, channel)

{

	_SYSCALL_DRIVER_DMA(dev, start);

	Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, start));

	return _impl_dma_start((struct device *)dev, channel);

}



_SYSCALL_HANDLER(dma_stop, dev, channel)

Z_SYSCALL_HANDLER(dma_stop, dev, channel)

{

	_SYSCALL_DRIVER_DMA(dev, stop);

	Z_OOPS(Z_SYSCALL_DRIVER_DMA(dev, stop));

	return _impl_dma_stop((struct device *)dev, channel);

}

drivers/entropy/entropy_handlers.c

+3 −3
Original line number Diff line number Diff line
@@ -7,10 +7,10 @@ 
#include <entropy.h>

#include <syscall_handler.h>



_SYSCALL_HANDLER(entropy_get_entropy, dev, buffer, len)

Z_SYSCALL_HANDLER(entropy_get_entropy, dev, buffer, len)

{

	_SYSCALL_DRIVER_ENTROPY(dev, get_entropy);

	_SYSCALL_MEMORY_WRITE(buffer, len);

	Z_OOPS(Z_SYSCALL_DRIVER_ENTROPY(dev, get_entropy));

	Z_OOPS(Z_SYSCALL_MEMORY_WRITE(buffer, len));

	return _impl_entropy_get_entropy((struct device *)dev, (u8_t *)buffer,

					 len);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE