Commit 6f595336 authored by Maxmillion McLaughlin's avatar Maxmillion McLaughlin Committed by Benjamin Cabé
Browse files

drivers: bmp581: change sensor_channel units to match spec 

The bmp581 driver currently returns pressure in pascals, when
the sensor_channel enum specifies kilopascals.

Signed-off-by: default avatarMaxmillion McLaughlin <max@sorcerer.earth>
parent 7e31f6be

drivers/sensor/bosch/bmp581/bmp581.c

+5 −5
Changes for drivers/sensor/bosch/bmp581/bmp581.c: 5 added lines, 5 removed lines.
Original line number Diff line number Diff line
@@ -376,14 +376,14 @@ static int bmp581_sample_fetch(const struct device *dev, enum sensor_channel cha 
		drv->last_sample.temperature.val2 = (data[1] << 8 | data[0]) * 10;



		if (drv->osr_odr_press_config.press_en == BMP5_ENABLE) {

			uint32_t raw_pressure = (uint32_t)((uint32_t)(data[5] << 16) |

							   (uint16_t)(data[4] << 8) | data[3]);

			/* convert raw sensor data to sensor_value. Shift the decimal part by

			 * 4 decimal places to compensate for the conversion in

			 * sensor_value_to_double()

			 */

			drv->last_sample.pressure.val1 = raw_pressure >> 6;

			drv->last_sample.pressure.val2 = (raw_pressure & BIT_MASK(6)) * 10000;

			uint32_t raw_pressure = (uint32_t)((uint32_t)(data[5] << 16) |

							   (uint16_t)(data[4] << 8) | data[3]) >> 6;

			drv->last_sample.pressure.val1 = raw_pressure / 1000;

			drv->last_sample.pressure.val2 = (raw_pressure % 1000) * 1000;

		} else {

			drv->last_sample.pressure.val1 = 0;

			drv->last_sample.pressure.val2 = 0;
@@ -404,7 +404,7 @@ static int bmp581_channel_get(const struct device *dev, enum sensor_channel chan 


	switch (chan) {

	case SENSOR_CHAN_PRESS:

		/* returns pressure in Pa */

		/* returns pressure in kPa */

		*val = drv->last_sample.pressure;

		return BMP5_OK;

	case SENSOR_CHAN_AMBIENT_TEMP:

CRA Git | Maintained and supported by SUSTech CRA and CCSE