Commit 6f474668 authored by Fabio Baltieri's avatar Fabio Baltieri Committed by Benjamin Cabé
Browse files

led: drop a bunch of on/off wrappers

These are now handled at API level, drop them from the drivers.

Signed-off-by: default avatarFabio Baltieri <fabiobaltieri@google.com>
parent 2f0d1417
Loading
Loading
Loading
Loading
+0 −12
Changes for drivers/led/is31fl3194.c: 0 added lines, 12 removed lines.
Original line number Diff line number Diff line
@@ -166,16 +166,6 @@ static int is31fl3194_set_brightness(const struct device *dev, uint32_t led, uin
	return ret;
}

static inline int is31fl3194_led_on(const struct device *dev, uint32_t led)
{
	return is31fl3194_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}

static inline int is31fl3194_led_off(const struct device *dev, uint32_t led)
{
	return is31fl3194_set_brightness(dev, led, 0);
}

/*
 * Counts red, green, blue channels; returns true if color_id is valid
 * and no more than one channel maps to the same color
@@ -315,8 +305,6 @@ static int is31fl3194_init(const struct device *dev)

static DEVICE_API(led, is31fl3194_led_api) = {
	.set_brightness = is31fl3194_set_brightness,
	.on = is31fl3194_led_on,
	.off = is31fl3194_led_off,
	.get_info = is31fl3194_get_info,
	.set_color = is31fl3194_set_color,
};
+0 −12
Changes for drivers/led/is31fl3216a.c: 0 added lines, 12 removed lines.
Original line number Diff line number Diff line
@@ -124,16 +124,6 @@ static int is31fl3216a_led_set_brightness(const struct device *dev,
	return is31fl3216a_update_pwm(&config->i2c);
}

static int is31fl3216a_led_on(const struct device *dev, uint32_t led)
{
	return is31fl3216a_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}

static int is31fl3216a_led_off(const struct device *dev, uint32_t led)
{
	return is31fl3216a_led_set_brightness(dev, led, 0);
}

static int is31fl3216a_init_registers(const struct i2c_dt_spec *i2c)
{
	int i;
@@ -224,8 +214,6 @@ static int is31fl3216a_init(const struct device *dev)

static DEVICE_API(led, is31fl3216a_led_api) = {
	.set_brightness = is31fl3216a_led_set_brightness,
	.on = is31fl3216a_led_on,
	.off = is31fl3216a_led_off,
	.write_channels = is31fl3216a_led_write_channels
};

+0 −12
Changes for drivers/led/is31fl3733.c: 0 added lines, 12 removed lines.
Original line number Diff line number Diff line
@@ -111,16 +111,6 @@ static int is31fl3733_led_set_brightness(const struct device *dev, uint32_t led,
	return i2c_reg_write_byte_dt(&config->bus, led, led_brightness);
}

static int is31fl3733_led_on(const struct device *dev, uint32_t led)
{
	return is31fl3733_led_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}

static int is31fl3733_led_off(const struct device *dev, uint32_t led)
{
	return is31fl3733_led_set_brightness(dev, led, 0);
}

static int is31fl3733_led_write_channels(const struct device *dev, uint32_t start_channel,
					 uint32_t num_channels, const uint8_t *buf)
{
@@ -274,8 +264,6 @@ int is31fl3733_current_limit(const struct device *dev, uint8_t limit)
}

static DEVICE_API(led, is31fl3733_api) = {
	.on = is31fl3733_led_on,
	.off = is31fl3733_led_off,
	.set_brightness = is31fl3733_led_set_brightness,
	.write_channels = is31fl3733_led_write_channels,
};
+0 −24
Changes for drivers/led/led_dac.c: 0 added lines, 24 removed lines.
Original line number Diff line number Diff line
@@ -49,31 +49,7 @@ static int led_dac_set_brightness(const struct device *dev, uint32_t led, uint8_
	return led_dac_set_raw(dev, led, value);
}

static inline int led_dac_on(const struct device *dev, uint32_t led)
{
	const struct led_dac_config *config = dev->config;

	if (led >= config->num_leds) {
		return -EINVAL;
	}

	return led_dac_set_raw(dev, led, config->leds[led].dac_max_brightness);
}

static inline int led_dac_off(const struct device *dev, uint32_t led)
{
	const struct led_dac_config *config = dev->config;

	if (led >= config->num_leds) {
		return -EINVAL;
	}

	return led_dac_set_raw(dev, led, 0);
}

static DEVICE_API(led, led_dac_api) = {
	.on = led_dac_on,
	.off = led_dac_off,
	.set_brightness = led_dac_set_brightness,
};

+0 −12
Changes for drivers/led/led_gpio.c: 0 added lines, 12 removed lines.
Original line number Diff line number Diff line
@@ -39,16 +39,6 @@ static int led_gpio_set_brightness(const struct device *dev, uint32_t led, uint8
	return gpio_pin_set_dt(led_gpio, value > 0);
}

static int led_gpio_on(const struct device *dev, uint32_t led)
{
	return led_gpio_set_brightness(dev, led, LED_BRIGTHNESS_MAX);
}

static int led_gpio_off(const struct device *dev, uint32_t led)
{
	return led_gpio_set_brightness(dev, led, 0);
}

static int led_gpio_init(const struct device *dev)
{
	const struct led_gpio_config *config = dev->config;
@@ -78,8 +68,6 @@ static int led_gpio_init(const struct device *dev)
}

static DEVICE_API(led, led_gpio_api) = {
	.on		= led_gpio_on,
	.off		= led_gpio_off,
	.set_brightness	= led_gpio_set_brightness,
};

Loading