Commit 4670214c authored by Jukka Rissanen's avatar Jukka Rissanen Committed by Anas Nashif
Browse files

net: gptp: Fix unsigned value comparison 



The nanosecond check was using <0 for unsigned value.

Coverity-CID: 187080
Fixes #8987

Signed-off-by: default avatarJukka Rissanen <jukka.rissanen@linux.intel.com>
parent 81a2c4b8

subsys/net/l2/ethernet/gptp/gptp_mi.c

+11 −1
Original line number Diff line number Diff line
@@ -707,11 +707,21 @@ static void gptp_update_local_port_clock(void) 
	if (second_diff || (second_diff == 0 &&

			    (nanosecond_diff < -5000 ||

			     nanosecond_diff > 5000))) {

		bool underflow = false;



		key = irq_lock();

		ptp_clock_get(clk, &tm);



		tm.second += second_diff;



		if (nanosecond_diff < 0 &&

		    tm.nanosecond < -nanosecond_diff) {

			underflow = true;

		}



		tm.nanosecond += nanosecond_diff;

		if (tm.nanosecond < 0) {



		if (underflow) {

			tm.second--;

			tm.nanosecond += NSEC_PER_SEC;

		} else if (tm.nanosecond >= NSEC_PER_SEC) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE