Commit 41bafc5d authored by Jamie McCrae's avatar Jamie McCrae Committed by Dan Kalowsky
Browse files

mgmt: mcumgr: grp: img_mgmt: Fix calling confirm 

Fixes calling the registered callbacks for image being confirmed
if the confirmation was not successful

Signed-off-by: default avatarJamie McCrae <jamie.mccrae@nordicsemi.no>
(cherry picked from commit 98d5aa37)
parent 37321f07

subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt_state.c

+5 −5
Changes for subsys/mgmt/mcumgr/grp/img_mgmt/src/img_mgmt_state.c: 5 added lines, 5 removed lines.
Original line number Diff line number Diff line
@@ -387,11 +387,6 @@ img_mgmt_state_confirm(void) 
{

	int rc;



#if defined(CONFIG_MCUMGR_GRP_IMG_STATUS_HOOKS)

	int32_t err_rc;

	uint16_t err_group;

#endif



	/* Confirm disallowed if a test is pending. */

	if (img_mgmt_state_any_pending()) {

		rc = IMG_MGMT_ERR_IMAGE_ALREADY_PENDING;
@@ -401,8 +396,13 @@ img_mgmt_state_confirm(void) 
	rc = img_mgmt_write_confirmed();



#if defined(CONFIG_MCUMGR_GRP_IMG_STATUS_HOOKS)

	if (!rc) {

		int32_t err_rc;

		uint16_t err_group;



		(void)mgmt_callback_notify(MGMT_EVT_OP_IMG_MGMT_DFU_CONFIRMED, NULL, 0, &err_rc,

					   &err_group);

	}

#endif



err:

CRA Git | Maintained and supported by SUSTech CRA and CCSE