net: gptp: Fix field ordering in gptp_priority_vector struct (3d8bae81) · Commits · Wenxi XU / zephyr

The steps_removed field must be placed right after root_system_id so that priority vector comparision can be done in one memcmp() call. This fixes the best master clock selection algorithm (BMCA). Signed-off-by:

Jukka Rissanen <jukka.rissanen@linux.intel.com>

subsys/net/l2/ethernet/gptp/gptp_state.h

+8 −6

Original line number	Diff line number	Diff line
		@@ -159,16 +159,18 @@ struct gptp_priority_vector {
		/** Identity of the source clock. */
		struct gptp_root_system_identity root_system_id;

		/** portNumber of the receiving port. */
		uint16_t port_number;
		/** Steps removed from the announce message transmitter and the
		* master clock. Note that this field must be right after
		* root_system_id as we are comparing root system id and steps
		* removed in one memcmp()
		*/
		uint16_t steps_removed;

		/** Port identity of the transmitting time-aware system. */
		struct gptp_port_identity src_port_id;

		/** Steps removed from the announce message transmitter and the
		* master clock.
		*/
		uint16_t steps_removed;
		/** Port number of the receiving port. */
		uint16_t port_number;
		} __packed;

		/* Pdelay Request state machine variables. */

Admin message