Commit 3c242d5e authored by Fin Maaß's avatar Fin Maaß Committed by Anas Nashif
Browse files

drivers: flash: spi_nor: fix config struct 



lots of values from the DT where not set corretly, if
`CONFIG_SPI_NOR_SFDP_RUNTIME` was
enabled. This fixes it.

Signed-off-by: default avatarFin Maaß <f.maass@vogl-electronic.com>
(cherry picked from commit 27aeabb5)
parent debf3e0f

drivers/flash/spi_nor.c

+20 −17
Original line number Diff line number Diff line
@@ -1666,30 +1666,33 @@ static const struct flash_driver_api spi_nor_api = { 
	DEFINE_PAGE_LAYOUT(idx)									\

	.flash_size = DT_INST_PROP(idx, size) / 8,						\

	.jedec_id = DT_INST_PROP(idx, jedec_id),						\

	IF_ENABLED(CONFIG_SPI_NOR_SFDP_MINIMAL, (CONFIGURE_4BYTE_ADDR(idx)))			\

	IF_ENABLED(CONFIG_SPI_NOR_SFDP_DEVICETREE,						\

		(.bfp_len = sizeof(bfp_##idx##_data) / 4,					\

		 .bfp = (const struct jesd216_bfp *)bfp_##idx##_data,))



#define GENERATE_CONFIG_STRUCT(idx)								\

	static const struct spi_nor_config spi_nor_##idx##_config = {				\

		.spi = SPI_DT_SPEC_INST_GET(idx, SPI_WORD_SET(8), CONFIG_SPI_NOR_CS_WAIT_DELAY),\

		.dpd_exist = DT_INST_PROP(idx, has_dpd),					\

		.dpd_wakeup_sequence_exist = DT_INST_NODE_HAS_PROP(idx, dpd_wakeup_sequence),	\

	.mxicy_mx25r_power_mode_exist = DT_INST_NODE_HAS_PROP(idx, mxicy_mx25r_power_mode),	\

		.mxicy_mx25r_power_mode_exist =							\

			DT_INST_NODE_HAS_PROP(idx, mxicy_mx25r_power_mode),			\

		.reset_gpios_exist = DT_INST_NODE_HAS_PROP(idx, reset_gpios),			\

		.requires_ulbpr_exist = DT_INST_PROP(idx, requires_ulbpr),			\

		.wp_gpios_exist = DT_INST_NODE_HAS_PROP(idx, wp_gpios),				\

		.hold_gpios_exist = DT_INST_NODE_HAS_PROP(idx, hold_gpios),			\

		IF_ENABLED(INST_HAS_LOCK(idx), (.has_lock = DT_INST_PROP(idx, has_lock),))	\

	IF_ENABLED(CONFIG_SPI_NOR_SFDP_MINIMAL, (CONFIGURE_4BYTE_ADDR(idx)))			\

	IF_ENABLED(CONFIG_SPI_NOR_SFDP_DEVICETREE,						\

		(.bfp_len = sizeof(bfp_##idx##_data) / 4,					\

		 .bfp = (const struct jesd216_bfp *)bfp_##idx##_data,))				\

		IF_ENABLED(ANY_INST_HAS_DPD, (INIT_T_ENTER_DPD(idx),))				\

	IF_ENABLED(UTIL_AND(ANY_INST_HAS_DPD, ANY_INST_HAS_T_EXIT_DPD), (INIT_T_EXIT_DPD(idx),))\

		IF_ENABLED(UTIL_AND(ANY_INST_HAS_DPD, ANY_INST_HAS_T_EXIT_DPD),			\

			(INIT_T_EXIT_DPD(idx),))						\

		IF_ENABLED(ANY_INST_HAS_DPD_WAKEUP_SEQUENCE, (INIT_WAKEUP_SEQ_PARAMS(idx),))	\

	IF_ENABLED(ANY_INST_HAS_MXICY_MX25R_POWER_MODE, (INIT_MXICY_MX25R_POWER_MODE(idx),))	\

		IF_ENABLED(ANY_INST_HAS_MXICY_MX25R_POWER_MODE,					\

			(INIT_MXICY_MX25R_POWER_MODE(idx),))					\

		IF_ENABLED(ANY_INST_HAS_RESET_GPIOS, (INIT_RESET_GPIOS(idx),))			\

		IF_ENABLED(ANY_INST_HAS_WP_GPIOS, (INIT_WP_GPIOS(idx),))			\

	IF_ENABLED(ANY_INST_HAS_HOLD_GPIOS, (INIT_HOLD_GPIOS(idx),))



#define GENERATE_CONFIG_STRUCT(idx)								\

	static const struct spi_nor_config spi_nor_##idx##_config = {				\

		.spi = SPI_DT_SPEC_INST_GET(idx, SPI_WORD_SET(8), CONFIG_SPI_NOR_CS_WAIT_DELAY),\

		COND_CODE_1(CONFIG_SPI_NOR_SFDP_RUNTIME, EMPTY(), (INST_CONFIG_STRUCT_GEN(idx)))};

		IF_ENABLED(ANY_INST_HAS_HOLD_GPIOS, (INIT_HOLD_GPIOS(idx),))			\

		IF_DISABLED(CONFIG_SPI_NOR_SFDP_RUNTIME, (INST_CONFIG_STRUCT_GEN(idx)))};



#define ASSIGN_PM(idx)							\

		PM_DEVICE_DT_INST_DEFINE(idx, spi_nor_pm_control);

CRA Git | Maintained and supported by SUSTech CRA and CCSE