Commit 32bd3aa7 authored Aug 07, 2023 by Robert Lubos Committed by Fabio Baltieri Aug 08, 2023

net: iface: Allow NULL pointer to be handled in net_if_is_ip_offloaded

In case native interface is used with NET_OFFLOAD enabled, the
net_if_is_ip_offloaded() could lead to a crash, if called on unbound
net_context (i.e. with no iface assigned to net_context yet).

As since commit 40d22402 the net_context
allocated on offloaded interface is always assigned with the iface
pointer during its creation, it can be safely assumed that in case of
NULL pointer is provided we deal with a native interface. Therefore
instead of asserting on the iface pointer, indicate that the interface
is native when NULL pointer is provided.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>

parent 90b5554b

include/zephyr/net/net_if.h

+2 −4

Changes for include/zephyr/net/net_if.h: 2 added lines, 4 removed lines.
Original line number	Diff line number	Diff line
		@@ -756,10 +756,8 @@ void net_if_queue_tx(struct net_if iface, struct net_pkt pkt);
		static inline bool net_if_is_ip_offloaded(struct net_if *iface)
		{
		#if defined(CONFIG_NET_OFFLOAD)
		NET_ASSERT(iface);
		NET_ASSERT(iface->if_dev);

		return (iface->if_dev->offload != NULL);
		return (iface != NULL && iface->if_dev != NULL &&
		iface->if_dev->offload != NULL);
		#else
		ARG_UNUSED(iface);

Admin message