Commit 07c3d452 authored by Abramo Bagnara's avatar Abramo Bagnara Committed by Anas Nashif
Browse files

coding guidelines: comply with MISRA C:2012 Rule 12.2 



- explicit with a cast the destination bitwidth of left shift
  ensuring to not break DTS

Signed-off-by: default avatarAbramo Bagnara <abramo.bagnara@bugseng.com>
parent f77c7bb2

include/dt-bindings/pcie/pcie.h

+7 −1
Original line number Diff line number Diff line
@@ -26,9 +26,15 @@ 
#define PCIE_ID_DEV_SHIFT	16U

#define PCIE_ID_DEV_MASK		0xFFFFU



#ifdef __DTS__

#define CAST(type, v) (v)

#else

#define CAST(type, v) ((type)(v))

#endif



#define PCIE_ID(vend, dev) \

	((((vend) & PCIE_ID_VEND_MASK) << PCIE_ID_VEND_SHIFT) | \

	 (((dev) & PCIE_ID_DEV_MASK) << PCIE_ID_DEV_SHIFT))

	 (CAST(uint32_t, (dev) & PCIE_ID_DEV_MASK) << PCIE_ID_DEV_SHIFT))



#define PCIE_ID_TO_VEND(id) (((id) >> PCIE_ID_VEND_SHIFT) & PCIE_ID_VEND_MASK)

#define PCIE_ID_TO_DEV(id)  (((id) >> PCIE_ID_DEV_SHIFT) & PCIE_ID_DEV_MASK)

CRA Git | Maintained and supported by SUSTech CRA and CCSE