Unverified Commit efa6e259 authored by Bharath Ramsundar's avatar Bharath Ramsundar Committed by GitHub
Browse files

Merge pull request #1274 from lilleswing/TextCNN-kernel-lengths

Automatically set an appropriate minimum sequence length of TextCNNModel
parents 1234be29 132dd24f
Loading
Loading
Loading
Loading
+14 −0
Original line number Diff line number Diff line
import unittest
from deepchem.models import TextCNNModel
from deepchem.models.tensorgraph.models.text_cnn import default_dict


class TestTextCNNModel(unittest.TestCase):

  def test_set_length(self):
    model = TextCNNModel(1, default_dict, 1)
    self.assertEqual(model.seq_length, max(model.kernel_sizes))

    large_length = 500
    model = TextCNNModel(1, default_dict, large_length)
    self.assertEqual(model.seq_length, large_length)
+1 −1
Original line number Diff line number Diff line
@@ -111,7 +111,7 @@ class TextCNNModel(TensorGraph):
    """
    self.n_tasks = n_tasks
    self.char_dict = char_dict
    self.seq_length = seq_length
    self.seq_length = max(seq_length, max(kernel_sizes))
    self.n_embedding = n_embedding
    self.kernel_sizes = kernel_sizes
    self.num_filters = num_filters