Unverified Commit e9ed95c2 authored by Axel Kohlmeyer's avatar Axel Kohlmeyer Committed by GitHub
Browse files

Merge pull request #1108 from akohlmey/fix-sprintf-buffer-overflows 

Avoid more buffer overflows due to using snprintf() on fixed size buffers
parents 33e33048 b915716b

src/GPU/pair_eam_alloy_gpu.cpp

+1 −1
Original line number Diff line number Diff line
@@ -364,7 +364,7 @@ void PairEAMAlloyGPU::read_file(char *filename) 
    fptr = fopen(filename,"r");

    if (fptr == NULL) {

      char str[128];

      sprintf(str,"Cannot open EAM potential file %s",filename);

      snprintf(str,128,"Cannot open EAM potential file %s",filename);

      error->one(FLERR,str);

    }

  }

src/GPU/pair_eam_fs_gpu.cpp

+1 −1
Original line number Diff line number Diff line
@@ -364,7 +364,7 @@ void PairEAMFSGPU::read_file(char *filename) 
    fptr = force->open_potential(filename);

    if (fptr == NULL) {

      char str[128];

      sprintf(str,"Cannot open EAM potential file %s",filename);

      snprintf(str,128,"Cannot open EAM potential file %s",filename);

      error->one(FLERR,str);

    }

  }

src/GRANULAR/fix_wall_gran_region.cpp

+4 −4
Original line number Diff line number Diff line
@@ -113,7 +113,7 @@ void FixWallGranRegion::init() 
      strcmp(region_style,region->style) != 0 ||

      nregion != region->nregion) {

    char str[256];

    sprintf(str,"Region properties for region %s changed between runs, "

    snprintf(str,256,"Region properties for region %s changed between runs, "

             "resetting its motion",idregion);

    error->warning(FLERR,str);

    region->reset_vel();
@@ -121,7 +121,7 @@ void FixWallGranRegion::init() 


  if (motion_resetflag){

    char str[256];

    sprintf(str,"Region properties for region %s are inconsistent "

    snprintf(str,256,"Region properties for region %s are inconsistent "

             "with restart file, resetting its motion",idregion);

    error->warning(FLERR,str);

    region->reset_vel();

src/KOKKOS/pair_eam_alloy_kokkos.cpp

+1 −1
Original line number Diff line number Diff line
@@ -992,7 +992,7 @@ void PairEAMAlloyKokkos<DeviceType>::read_file(char *filename) 
    fptr = force->open_potential(filename);

    if (fptr == NULL) {

      char str[128];

      sprintf(str,"Cannot open EAM potential file %s",filename);

      snprintf(str,128,"Cannot open EAM potential file %s",filename);

      error->one(FLERR,str);

    }

  }

src/KOKKOS/pair_eam_fs_kokkos.cpp

+1 −1
Original line number Diff line number Diff line
@@ -992,7 +992,7 @@ void PairEAMFSKokkos<DeviceType>::read_file(char *filename) 
    fptr = force->open_potential(filename);

    if (fptr == NULL) {

      char str[128];

      sprintf(str,"Cannot open EAM potential file %s",filename);

      snprintf(str,128,"Cannot open EAM potential file %s",filename);

      error->one(FLERR,str);

    }

  }

CRA Git | Maintained and supported by SUSTech CRA and CCSE