Unverified Commit a9f8b17c authored by Axel Kohlmeyer's avatar Axel Kohlmeyer Committed by GitHub
Browse files

Merge pull request #1282 from akohlmey/collected-small-changes

Collected small changes and bugfixes for the next patch release
parents d6a918f4 f28ab596
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -756,7 +756,7 @@ endif()
# Basic system tests (standard libraries, headers, functions, types)   #
########################################################################
include(CheckIncludeFileCXX)
foreach(HEADER math.h)
foreach(HEADER cmath)
  check_include_file_cxx(${HEADER} FOUND_${HEADER})
  if(NOT FOUND_${HEADER})
    message(FATAL_ERROR "Could not find needed header - ${HEADER}")
+11 −8
Original line number Diff line number Diff line
@@ -50,8 +50,8 @@ This is indicated by who the pull request is assigned to. LAMMPS core
developers can self-assign or they can decide to assign a pull request
to a different LAMMPS developer. Being assigned to a pull request means,
that this pull request may need some work and the assignee is tasked to
determine what this might be needed or not, and may either implement the
required changes or ask the submitter of the pull request to implement
determine whether this might be needed or not, and may either implement
the required changes or ask the submitter of the pull request to implement
them.  Even though, all LAMMPS developers may have write access to pull
requests (if enabled by the submitter, which is the default), only the
submitter or the assignee of a pull request may do so.  During this
@@ -76,12 +76,15 @@ People can be assigned to review a pull request in two ways:
Reviewers are requested to state their appraisal of the proposed changes
and either approve or request changes. People may unassign themselves
from review, if they feel not competent about the changes proposed. At
least one review from a LAMMPS developer with write access is required
before merging in addition to the automated compilation tests.  The
feature, that reviews from code owners are "hard" reviews (i.e. they
must all be approved before merging is allowed), is currently disabled
and it is in the discretion of the merge maintainer to assess when
a sufficient degree of approval has been reached.  Reviews may be
least two approvals from LAMMPS developers with write access are required
before merging in addition to the automated compilation tests.
Merging counts as implicit approval, so does submission of a pull request
(by a LAMMPS developer). So the person doing the merge may not also submit
an approving review. The feature, that reviews from code owners are "hard"
reviews (i.e. they must all be approved before merging is allowed), is
currently disabled and it is in the discretion of the merge maintainer to
assess when a sufficient degree of approval, especially from external
contributors, has been reached in these cases.  Reviews may be
(automatically) dismissed, when the reviewed code has been changed,
and then approval is required a second time.

+1 −1
Original line number Diff line number Diff line
@@ -78,7 +78,7 @@ description of the Python interface to LAMMPS, which wraps the C-style
interface.

See the sample codes in examples/COUPLE/simple for examples of C++ and
C and Fortran codes that invoke LAMMPS thru its library interface.
C and Fortran codes that invoke LAMMPS through its library interface.
Other examples in the COUPLE directory use coupling ideas discussed on
the "Howto couple"_Howto_couple.html doc page.

+1 −1
Original line number Diff line number Diff line
@@ -6917,7 +6917,7 @@ types. :dd

{Invalid use of library file() function} :dt

This function is called thru the library interface.  This
This function is called through the library interface.  This
error should not occur.  Contact the developers if it does. :dd

{Invalid value in set command} :dt

doc/src/Howto_bash.txt

100755 → 100644
+0 −0

File mode changed from 100755 to 100644.

Loading