Unverified Commit 6ee002d6 authored by Axel Kohlmeyer's avatar Axel Kohlmeyer
Browse files

add cmake support for enhanced missing style error reports

parent d640c712

cmake/CMakeLists.txt

+18 −18
Original line number Diff line number Diff line
@@ -87,6 +87,7 @@ string(TOUPPER "${CMAKE_BUILD_TYPE}" BTYPE) 
# this is fast, so check for it all the time

message(STATUS "Running check for auto-generated files from make-based build system")

file(GLOB SRC_AUTOGEN_FILES ${LAMMPS_SOURCE_DIR}/style_*.h)

file(GLOB SRC_AUTOGEN_FILES ${LAMMPS_SOURCE_DIR}/packages_*.h)

list(APPEND SRC_AUTOGEN_FILES ${LAMMPS_SOURCE_DIR}/lmpinstalledpkgs.h ${LAMMPS_SOURCE_DIR}/lmpgitversion.h)

foreach(_SRC ${SRC_AUTOGEN_FILES})

  get_filename_component(FILENAME "${_SRC}" NAME)
@@ -172,21 +173,17 @@ set(LAMMPS_LINK_LIBS) 
set(LAMMPS_DEPS)

set(LAMMPS_API_DEFINES)



set(DEFAULT_PACKAGES ASPHERE BODY CLASS2 COLLOID COMPRESS DIPOLE GRANULAR

  KSPACE MANYBODY MC MESSAGE MISC MOLECULE PERI REPLICA RIGID SHOCK

  SPIN SNAP SRD KIM PYTHON MSCG MPIIO VORONOI POEMS LATTE USER-ATC USER-AWPMD

  USER-BOCS USER-CGDNA USER-MESO USER-CGSDK USER-COLVARS USER-DIFFRACTION

  USER-DPD USER-DRUDE USER-EFF USER-FEP USER-H5MD USER-LB USER-MANIFOLD

  USER-MEAMC USER-MGPT USER-MISC USER-MOFFF USER-MOLFILE USER-NETCDF

  USER-PHONON USER-PLUMED USER-PTM USER-QTB USER-REAXC USER-SCAFACOS

  USER-SDPD USER-SMD USER-SMTBQ USER-SPH USER-TALLY USER-UEF USER-VTK

  USER-QUIP USER-QMMM USER-YAFF USER-ADIOS)

set(DEFAULT_PACKAGES ASPHERE BODY CLASS2 COLLOID COMPRESS CORESHELL DIPOLE

  GRANULAR KSPACE LATTE MANYBODY MC MESSAGE MISC MOLECULE PERI POEMS QEQ

  REPLICA RIGID SHOCK SPIN SNAP SRD KIM PYTHON MSCG MPIIO VORONOI

  USER-ATC USER-AWPMD USER-BOCS USER-CGDNA USER-MESO USER-CGSDK USER-COLVARS

  USER-DIFFRACTION USER-DPD USER-DRUDE USER-EFF USER-FEP USER-H5MD USER-LB

  USER-MANIFOLD USER-MEAMC USER-MGPT USER-MISC USER-MOFFF USER-MOLFILE

  USER-NETCDF USER-PHONON USER-PLUMED USER-PTM USER-QTB USER-REAXC

  USER-SCAFACOS USER-SDPD USER-SMD USER-SMTBQ USER-SPH USER-TALLY USER-UEF

  USER-VTK USER-QUIP USER-QMMM USER-YAFF USER-ADIOS)

set(ACCEL_PACKAGES USER-OMP KOKKOS OPT USER-INTEL GPU)

set(OTHER_PACKAGES CORESHELL QEQ)

foreach(PKG ${DEFAULT_PACKAGES})

  option(PKG_${PKG} "Build ${PKG} Package" OFF)

endforeach()

foreach(PKG ${ACCEL_PACKAGES} ${OTHER_PACKAGES})

foreach(PKG ${DEFAULT_PACKAGES} ${ACCEL_PACKAGES})

  option(PKG_${PKG} "Build ${PKG} Package" OFF)

endforeach()
@@ -213,7 +210,6 @@ if(PKG_USER-ADIOS) 
  list(APPEND LAMMPS_LINK_LIBS adios2::adios2)

endif()





# do MPI detection after language activation, if MPI for these language is required

find_package(MPI QUIET)

option(BUILD_MPI "Build MPI version" ${MPI_FOUND})
@@ -233,7 +229,6 @@ else() 
  list(APPEND LAMMPS_LINK_LIBS mpi_stubs)

endif()





set(LAMMPS_SIZES "smallbig" CACHE STRING "LAMMPS integer sizes (smallsmall: all 32-bit, smallbig: 64-bit #atoms #timesteps, bigbig: also 64-bit imageint, 64-bit atom ids)")

set(LAMMPS_SIZES_VALUES smallbig bigbig smallsmall)

set_property(CACHE LAMMPS_SIZES PROPERTY STRINGS ${LAMMPS_SIZES_VALUES})
@@ -844,6 +839,8 @@ foreach(PKG ${DEFAULT_PACKAGES}) 
    list(APPEND LIB_SOURCES ${${PKG}_SOURCES})

    include_directories(${${PKG}_SOURCES_DIR})

  endif()



  RegisterPackages(${${PKG}_SOURCES_DIR})

endforeach()



# packages that need defines set
@@ -862,6 +859,8 @@ foreach(PKG ${ACCEL_PACKAGES}) 


  # check for package files in src directory due to old make system

  DetectBuildSystemConflict(${LAMMPS_SOURCE_DIR} ${${PKG}_SOURCES} ${${PKG}_HEADERS})



  RegisterPackages(${${PKG}_SOURCES_DIR})

endforeach()



##############################################
@@ -1370,6 +1369,7 @@ endif() 
set(LAMMPS_STYLE_HEADERS_DIR ${CMAKE_CURRENT_BINARY_DIR}/styles)



GenerateStyleHeaders(${LAMMPS_STYLE_HEADERS_DIR})

GeneratePackagesHeaders(${LAMMPS_STYLE_HEADERS_DIR})



include_directories(${LAMMPS_STYLE_HEADERS_DIR})
@@ -1378,7 +1378,7 @@ include_directories(${LAMMPS_STYLE_HEADERS_DIR}) 
######################################

set(temp "#ifndef LMP_INSTALLED_PKGS_H\n#define LMP_INSTALLED_PKGS_H\n")

set(temp "${temp}const char * LAMMPS_NS::LAMMPS::installed_packages[] =  {\n")

set(temp_PKG_LIST ${DEFAULT_PACKAGES} ${ACCEL_PACKAGES} ${OTHER_PACKAGES})

set(temp_PKG_LIST ${DEFAULT_PACKAGES} ${ACCEL_PACKAGES})

list(SORT temp_PKG_LIST)

foreach(PKG ${temp_PKG_LIST})

    if(PKG_${PKG})
@@ -1598,7 +1598,7 @@ endif() 
###############################################################################

# Print package summary

###############################################################################

foreach(PKG ${DEFAULT_PACKAGES} ${ACCEL_PACKAGES} ${OTHER_PACKAGES})

foreach(PKG ${DEFAULT_PACKAGES} ${ACCEL_PACKAGES})

  if(PKG_${PKG})

    message(STATUS "Building package: ${PKG}")

  endif()

cmake/Modules/StyleHeaderUtils.cmake

+85 −0
Original line number Diff line number Diff line
@@ -181,3 +181,88 @@ function(DetectBuildSystemConflict lammps_src_dir) 
    endforeach()

  endif()

endfunction(DetectBuildSystemConflict)





function(FindPackagesHeaders path style_class file_pattern headers)

    file(GLOB files "${path}/${file_pattern}*.h")

    get_property(plist GLOBAL PROPERTY ${headers})



    foreach(file_name ${files})

        file(STRINGS ${file_name} is_style LIMIT_COUNT 1 REGEX ${style_class})

        if(is_style)

            list(APPEND plist ${file_name})

        endif()

    endforeach()

    set_property(GLOBAL PROPERTY ${headers} "${plist}")

endfunction(FindPackagesHeaders)



function(RegisterPackages search_path)

    FindPackagesHeaders(${search_path} ANGLE_CLASS     angle_     PKGANGLE     ) # angle     ) # force

    FindPackagesHeaders(${search_path} ATOM_CLASS      atom_vec_  PKGATOM_VEC  ) # atom      ) # atom      atom_vec_hybrid

    FindPackagesHeaders(${search_path} BODY_CLASS      body_      PKGBODY      ) # body      ) # atom_vec_body

    FindPackagesHeaders(${search_path} BOND_CLASS      bond_      PKGBOND      ) # bond      ) # force

    FindPackagesHeaders(${search_path} COMMAND_CLASS   "[^.]"     PKGCOMMAND   ) # command   ) # input

    FindPackagesHeaders(${search_path} COMPUTE_CLASS   compute_   PKGCOMPUTE   ) # compute   ) # modify

    FindPackagesHeaders(${search_path} DIHEDRAL_CLASS  dihedral_  PKGDIHEDRAL  ) # dihedral  ) # force

    FindPackagesHeaders(${search_path} DUMP_CLASS      dump_      PKGDUMP      ) # dump      ) # output    write_dump

    FindPackagesHeaders(${search_path} FIX_CLASS       fix_       PKGFIX       ) # fix       ) # modify

    FindPackagesHeaders(${search_path} IMPROPER_CLASS  improper_  PKGIMPROPER  ) # improper  ) # force

    FindPackagesHeaders(${search_path} INTEGRATE_CLASS "[^.]"     PKGINTEGRATE ) # integrate ) # update

    FindPackagesHeaders(${search_path} KSPACE_CLASS    "[^.]"     PKGKSPACE    ) # kspace    ) # force

    FindPackagesHeaders(${search_path} MINIMIZE_CLASS  min_       PKGMINIMIZE  ) # minimize  ) # update

    FindPackagesHeaders(${search_path} NBIN_CLASS      nbin_      PKGNBIN      ) # nbin      ) # neighbor

    FindPackagesHeaders(${search_path} NPAIR_CLASS     npair_     PKGNPAIR     ) # npair     ) # neighbor

    FindPackagesHeaders(${search_path} NSTENCIL_CLASS  nstencil_  PKGNSTENCIL  ) # nstencil  ) # neighbor

    FindPackagesHeaders(${search_path} NTOPO_CLASS     ntopo_     PKGNTOPO     ) # ntopo     ) # neighbor

    FindPackagesHeaders(${search_path} PAIR_CLASS      pair_      PKGPAIR      ) # pair      ) # force

    FindPackagesHeaders(${search_path} READER_CLASS    reader_    PKGREADER    ) # reader    ) # read_dump

    FindPackagesHeaders(${search_path} REGION_CLASS    region_    PKGREGION    ) # region    ) # domain

endfunction(RegisterPackages)



function(CreatePackagesHeader path filename)

  set(temp "")

  if(ARGC GREATER 2)

    list(REMOVE_AT ARGV 0 1)

    foreach(FNAME ${ARGV})

      set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${FNAME}")

      get_filename_component(DNAME ${FNAME} DIRECTORY)

      get_filename_component(DNAME ${DNAME} NAME)

      get_filename_component(FNAME ${FNAME} NAME)

      set(temp "${temp}#undef PACKAGE\n#define PACKAGE \"${DNAME}\"\n")

      set(temp "${temp}#include \"${DNAME}/${FNAME}\"\n")

    endforeach()

  endif()

  message(STATUS "Generating ${filename}...")

  file(WRITE "${path}/${filename}.tmp" "${temp}" )

  execute_process(COMMAND ${CMAKE_COMMAND} -E copy_if_different "${path}/${filename}.tmp" "${path}/${filename}")

  set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${path}/${filename}")

endfunction(CreatePackagesHeader)



function(GeneratePackagesHeader path property style)

  get_property(files GLOBAL PROPERTY ${property})

  CreatePackagesHeader("${path}" "packages_${style}.h" ${files})

endfunction(GeneratePackagesHeader)



function(GeneratePackagesHeaders output_path)

    GeneratePackagesHeader(${output_path} PKGANGLE      angle     ) # force

    GeneratePackagesHeader(${output_path} PKGATOM_VEC   atom      ) # atom      atom_vec_hybrid

    GeneratePackagesHeader(${output_path} PKGBODY       body      ) # atom_vec_body

    GeneratePackagesHeader(${output_path} PKGBOND       bond      ) # force

    GeneratePackagesHeader(${output_path} PKGCOMMAND    command   ) # input

    GeneratePackagesHeader(${output_path} PKGCOMPUTE    compute   ) # modify

    GeneratePackagesHeader(${output_path} PKGDIHEDRAL   dihedral  ) # force

    GeneratePackagesHeader(${output_path} PKGDUMP       dump      ) # output    write_dump

    GeneratePackagesHeader(${output_path} PKGFIX        fix       ) # modify

    GeneratePackagesHeader(${output_path} PKGIMPROPER   improper  ) # force

    GeneratePackagesHeader(${output_path} PKGINTEGRATE  integrate ) # update

    GeneratePackagesHeader(${output_path} PKGKSPACE     kspace    ) # force

    GeneratePackagesHeader(${output_path} PKGMINIMIZE   minimize  ) # update

    GeneratePackagesHeader(${output_path} PKGNBIN       nbin      ) # neighbor

    GeneratePackagesHeader(${output_path} PKGNPAIR      npair     ) # neighbor

    GeneratePackagesHeader(${output_path} PKGNSTENCIL   nstencil  ) # neighbor

    GeneratePackagesHeader(${output_path} PKGNTOPO      ntopo     ) # neighbor

    GeneratePackagesHeader(${output_path} PKGPAIR       pair      ) # force

    GeneratePackagesHeader(${output_path} PKGREADER     reader    ) # read_dump

    GeneratePackagesHeader(${output_path} PKGREGION     region    ) # domain

endfunction(GeneratePackagesHeaders)

CRA Git | Maintained and supported by SUSTech CRA and CCSE