fix: proper apostrophe in stats card's header (dd2c7ed2) · Commits · 郑智淋 / github-readme-stats

src/renderStatsCard.js

+3 −1

Original line number	Diff line number	Diff line
		@@ -124,9 +124,11 @@ const renderStatsCard = (stats = {}, options = { hide: [] }) => {
		});

		// Conditionally rendered elements

		const apostrophe = ["x", "s"].includes(name.slice(-1)) ? "" : "s";
		const title = hide_title
		? ""
		: `<text x="25" y="35" class="header">${name}'s GitHub Stats</text>`;
		: `<text x="25" y="35" class="header">${name}'${apostrophe} GitHub Stats</text>`;

		const border = hide_border
		? ""

+14 −0

Original line number	Diff line number	Diff line
		@@ -39,6 +39,20 @@ describe("Test renderStatsCard", () => {
		expect(queryByTestId(document.body, "rank-circle")).toBeInTheDocument();
		});

		it("should have proper name apostrophe", () => {
		document.body.innerHTML = renderStatsCard({ ...stats, name: "Anil Das" });

		expect(document.getElementsByClassName("header")[0].textContent).toBe(
		"Anil Das' GitHub Stats"
		);

		document.body.innerHTML = renderStatsCard({ ...stats, name: "Felix" });

		expect(document.getElementsByClassName("header")[0].textContent).toBe(
		"Felix' GitHub Stats"
		);
		});

		it("should hide individual stats", () => {
		document.body.innerHTML = renderStatsCard(stats, {
		hide: "['issues', 'prs', 'contribs']",